From 2fef140e79391f081af63cae37f414aec8da7842 Mon Sep 17 00:00:00 2001 From: John Benediktsson Date: Thu, 23 Aug 2012 18:07:25 -0700 Subject: [PATCH] xml.name: simpler parse-name makes benchmark 12% faster. --- basis/xml/name/name.factor | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/basis/xml/name/name.factor b/basis/xml/name/name.factor index dd83e892ba..77685e35b2 100644 --- a/basis/xml/name/name.factor +++ b/basis/xml/name/name.factor @@ -53,10 +53,15 @@ SYMBOL: ns-stack } 2&& ] if-empty ; + ] [ 2drop f ] if ; : prefixed-name ( str -- name/f ) @@ -68,10 +73,9 @@ SYMBOL: ns-stack ] [ drop f ] if* ; : interpret-name ( str -- name ) - dup prefixed-name [ ] [ - dup valid-name? - [ ] [ bad-name ] if - ] ?if ; + dup prefixed-name [ ] [ ] ?if ; + +PRIVATE> : take-name ( -- string ) version-1.0? '[ _ swap name-char? not ] take-until ;