From 305ba30e96ff61bd85d1b2eb863148b90bff63dc Mon Sep 17 00:00:00 2001
From: John Benediktsson <mrjbq7@gmail.com>
Date: Sat, 15 Nov 2014 16:52:31 -0800
Subject: [PATCH] splitting.monotonic: faster monotonic-split.

---
 basis/splitting/monotonic/monotonic-tests.factor | 11 +++++++----
 basis/splitting/monotonic/monotonic.factor       | 12 ++++--------
 2 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/basis/splitting/monotonic/monotonic-tests.factor b/basis/splitting/monotonic/monotonic-tests.factor
index 64d1ac0ee6..4703f0273a 100644
--- a/basis/splitting/monotonic/monotonic-tests.factor
+++ b/basis/splitting/monotonic/monotonic-tests.factor
@@ -2,10 +2,13 @@ IN: splitting.monotonic
 USING: tools.test math arrays kernel sequences ;
 
 { { } } [ { } [ < ] monotonic-split ] unit-test
-[ { { 1 } { -1 5 } { 2 4 } } ]
-[ { 1 -1 5 2 4 } [ < ] monotonic-split [ >array ] map ] unit-test
-[ { { 1 1 1 1 } { 2 2 } { 3 } { 4 } { 5 } { 6 6 6 } } ]
-[ { 1 1 1 1 2 2 3 4 5 6 6 6 } [ = ] monotonic-split [ >array ] map ] unit-test
+{ { V{ 1 } } } [ { 1 } [ < ] monotonic-split ] unit-test
+{ { V{ 1 2 } } } [ { 1 2 } [ < ] monotonic-split ] unit-test
+{ { V{ 1 } V{ 2 } } } [ { 1 2 } [ > ] monotonic-split ] unit-test
+[ { V{ 1 } V{ -1 5 } V{ 2 4 } } ]
+[ { 1 -1 5 2 4 } [ < ] monotonic-split ] unit-test
+[ { V{ 1 1 1 1 } V{ 2 2 } V{ 3 } V{ 4 } V{ 5 } V{ 6 6 6 } } ]
+[ { 1 1 1 1 2 2 3 4 5 6 6 6 } [ = ] monotonic-split ] unit-test
 
 [ { } ]
 [ { } [ = ] slice monotonic-slice ] unit-test
diff --git a/basis/splitting/monotonic/monotonic.factor b/basis/splitting/monotonic/monotonic.factor
index 2e37b1d279..6c7f3463a5 100644
--- a/basis/splitting/monotonic/monotonic.factor
+++ b/basis/splitting/monotonic/monotonic.factor
@@ -7,15 +7,11 @@ IN: splitting.monotonic
 
 <PRIVATE
 
-: ,, ( obj -- ) building get last push ;
-: v, ( -- ) V{ } clone , ;
-: ,v ( -- ) building get dup last empty? [ dup pop* ] when drop ;
-
 : (monotonic-split) ( seq quot -- newseq )
-    [
-        [ dup unclip suffix ] dip
-        v, '[ over ,, @ [ v, ] unless ] 2each ,v
-    ] { } make ; inline
+    [ V{ } clone V{ } clone ] 2dip [ ] swap '[
+        [ [ over push ] keep ] dip
+        [ @ [ over push V{ } clone ] unless ] keep
+    ] map-reduce over push over push { } like ; inline
 
 PRIVATE>