compiler.cfg.*: new word reset-vreg-counter, useful for making test writing more convenient

basis/compiler/cfg/builder/builder-tests.factor

@@ -248,9 +248,8 @@ IN: compiler.cfg.builder.tests
 {
     { T{ ##load-integer { dst 78 } { val 0 } } }
 } [
-    initial-height-state height-state set
+    test-init
     77 vreg-counter set-global
-    H{ } clone replace-mapping set
     [
         T{ #push { literal 0 } { out-d { 8537399 } } } emit-node
     ] { } make
@@ -260,9 +259,7 @@ IN: compiler.cfg.builder.tests
     { { 1 1 } { 0 0 } }
     H{ { D -1 4 } { D 0 4 } }
 } [
-    0 vreg-counter set-global
+    test-init
-    initial-height-state height-state set
-    H{ } clone replace-mapping set
     4 D 0 replace-loc
     T{ #shuffle
        { mapping { { 2 4 } { 3 4 } } }

basis/compiler/cfg/debugger/debugger.factor

@@ -18,12 +18,10 @@ IN: compiler.cfg.debugger
 GENERIC: test-builder ( quot -- cfgs )
 
 M: callable test-builder
-    0 vreg-counter set-global
+    reset-vreg-counter build-tree optimize-tree gensym build-cfg ;
-    build-tree optimize-tree gensym build-cfg ;
 
 M: word test-builder
-    0 vreg-counter set-global
+    [ reset-vreg-counter build-tree optimize-tree ] keep build-cfg ;
-    [ build-tree optimize-tree ] keep build-cfg ;
 
 : test-ssa ( quot -- cfgs )
     test-builder [

basis/compiler/cfg/gc-checks/gc-checks-tests.factor

@@ -103,8 +103,6 @@ V{
 
 [ ] [ 1 get instructions>> allocation-size 123 <alien> size assert= ] unit-test
 
-2 vreg-counter set-global
-
 : gc-check? ( bb -- ? )
     instructions>>
     {
@@ -119,11 +117,9 @@ V{
         T{ ##branch }
     } = ;
 
-4 vreg-counter set-global
-
 [ t ] [ <gc-call> gc-call? ] unit-test
 
-30 vreg-counter set-global
+reset-vreg-counter
 
 V{
     T{ ##prologue }

basis/compiler/cfg/registers/registers.factor

@@ -8,6 +8,9 @@ SYMBOL: vreg-counter
 : next-vreg ( -- vreg )
     vreg-counter counter ;
 
+: reset-vreg-counter ( -- )
+    0 vreg-counter set-global ;
+
 SYMBOL: representations
 
 ERROR: bad-vreg vreg ;

basis/compiler/cfg/ssa/construction/construction-tests.factor

@@ -8,8 +8,7 @@ IN: compiler.cfg.ssa.construction.tests
 
 : reset-counters ( -- )
     ! Reset counters so that results are deterministic w.r.t. hash order
-    0 vreg-counter set-global
+    reset-vreg-counter 0 basic-block set-global ;
-    0 basic-block set-global ;
 
 : test-ssa ( -- )
     0 get block>cfg

basis/compiler/cfg/stacks/local/local-tests.factor

@@ -24,8 +24,8 @@ IN: compiler.cfg.stacks.local.tests
     { { 0 4  } { 0 -2 } } height-state>insns
 ] unit-test
 
-{ 30 } [
+{ 1 } [
-    29 vreg-counter set-global <bihash> locs>vregs set D 0 loc>vreg
+    test-init D 0 loc>vreg
 ] unit-test
 
 {
@@ -34,8 +34,7 @@ IN: compiler.cfg.stacks.local.tests
         T{ ##copy { dst 2 } { src 26 } { rep any-rep } }
     }
 } [
-    0 vreg-counter set-global <bihash> locs>vregs set
+    test-init { { D 0 25 } { R 0 26 } } stack-changes
-    { { D 0 25 } { R 0 26 } } stack-changes
 ] unit-test
 
 { 80 } [
@@ -52,8 +51,7 @@ IN: compiler.cfg.stacks.local.tests
 
 { 0 } [
     V{ } 0 insns>block basic-block set
-    begin-stack-analysis begin-local-analysis
+    test-init compute-local-kill-set assoc-size
-    compute-local-kill-set assoc-size
 ] unit-test
 
 { H{ { R -4 R -4 } } } [

basis/compiler/cfg/stacks/stacks-tests.factor

@@ -4,11 +4,8 @@ tools.test ;
 IN: compiler.cfg.stacks.tests
 
 : test-init ( -- )
-    0 vreg-counter set-global
+    reset-vreg-counter begin-stack-analysis begin-local-analysis
-    initial-height-state height-state set
+    H{ } clone replace-mapping set ;
-    H{ } clone replace-mapping set
-    H{ } clone locs>vregs set
-    H{ } clone local-peek-set set ;
 
 {
     H{ { D 1 4 } { D 2 3 } { D 0 5 } }

basis/compiler/tests/codegen.factor

@@ -532,7 +532,7 @@ TUPLE: myseq { underlying1 byte-array read-only } { underlying2 byte-array read-
 ! Stupid repro
 USE: compiler.cfg.registers
 
-0 vreg-counter set-global
+reset-vreg-counter
 
 { fib-count2 } compile