Reuse tool windows when they are already open; simplify some code

doc/handbook/handbook.facts

@@ -49,4 +49,4 @@ ARTICLE: "type-index" "Type index"
 { $outliner [ builtins get [ ] subset ] } ;
 
 ARTICLE: "class-index" "Class index"
-{ $outliner [ classes get [ ] subset ] } ;
+{ $outliner [ classes ] } ;

library/ui/backend.factor

@@ -7,6 +7,8 @@ DEFER: draw-world ! defined in world.factor
 
 DEFER: open-window* ( world title -- )
 
+DEFER: raise-window ( world -- )
+
 DEFER: select-gl-context ( handle -- )
 
 DEFER: flush-gl-context ( handle -- )

library/ui/cocoa/ui.factor

@@ -51,6 +51,9 @@ IN: gadgets
     dup start-world
     world-handle second f -> makeKeyAndOrderFront: ;
 
+: raise-window ( world -- )
+    world-handle second -> makeMainWindow ;
+
 : select-gl-context ( handle -- )
     first -> openGLContext -> makeCurrentContext ;
 

library/ui/tools/search.factor

@@ -35,10 +35,8 @@ M: search-gadget pref-dim* drop { 400 500 } ;
 
 : apropos-window
     [ apropos ] <search-gadget>
-    "Apropos" <titled-gadget>
-    open-window ;
+    "Apropos" open-titled-window ;
 
 : search-help-window
     [ search-help. ] <search-gadget>
-    "Search help" <titled-gadget>
-    open-window ;
+    "Search help" open-titled-window ;

library/ui/ui.factor

@@ -1,9 +1,9 @@
 ! Copyright (C) 2006 Slava Pestov.
 ! See http://factorcode.org/license.txt for BSD license.
 IN: gadgets
-USING: arrays gadgets gadgets-labels gadgets-theme
-gadgets-viewports hashtables kernel math namespaces queues
-sequences threads ;
+USING: arrays gadgets gadgets-frames gadgets-labels
+gadgets-theme gadgets-viewports hashtables kernel math
+namespaces queues sequences threads ;
 
 ! Assoc mapping aliens to gadgets
 SYMBOL: windows
@@ -66,17 +66,11 @@ TUPLE: titled-gadget title ;
 
 M: titled-gadget gadget-title titled-gadget-title ;
 
-M: titled-gadget pref-dim* viewport-dim ;
-
-M: titled-gadget layout*
-    dup rect-dim swap gadget-child set-layout-dim ;
-
 M: titled-gadget focusable-child* gadget-child ;
 
 C: titled-gadget ( gadget title -- )
-    dup delegate>gadget
     [ set-titled-gadget-title ] keep
-    [ add-gadget ] keep ;
+    { { [ ] f @center } } make-frame* ;
 
 : update-title ( gadget -- )
     dup gadget-parent dup world?
@@ -88,15 +82,21 @@ C: titled-gadget ( gadget title -- )
 : open-titled-window ( gadget title -- )
     <titled-gadget> open-window ;
 
+: find-window ( quot -- world )
+    windows get [ second ] map
+    [ world-gadget swap call ] find-last-with nip ; inline
+
 : open-tool ( arg cons setter -- )
     >r call tuck r> call open-window ; inline
 
 : call-tool ( arg pred cons setter -- )
-    >r >r frontmost-window world-gadget swap call [
-        frontmost-window world-gadget r> drop r> call
+    rot find-window [
+        rot drop
+        dup raise-window
+        world-gadget swap call
     ] [
-        r> r> open-tool
-    ] if ; inline
+        open-tool
+    ] if* ; inline
 
 : start-world ( world -- )
     dup add-notify

library/ui/x11/ui.factor

@@ -135,6 +135,9 @@ IN: gadgets
     dup gadget-window dup start-world
     world-handle first map-window* ;
 
+: raise-window ( world -- )
+    dpy get swap second XRaiseWindow drop ;
+
 : select-gl-context ( handle -- )
     dpy get swap first2 glXMakeCurrent
     [ "Failed to set current GLX context" throw ] unless ;