From 69ee8b9190d2e59115d493e8f03e14f43e2b954e Mon Sep 17 00:00:00 2001
From: Doug Coleman <doug.coleman@gmail.com>
Date: Tue, 30 Jun 2015 08:51:07 -0700
Subject: [PATCH] core, basis: Don't use the IN: foo.private feature and
 undocument it. It only works well when you are loading code dynamically.

---
 basis/math/combinatorics/combinatorics-docs.factor |  2 --
 basis/math/complex/complex.factor                  |  6 +++++-
 basis/tools/deploy/shaker/strip-destructors.factor |  6 +++++-
 core/math/floats/floats.factor                     |  5 ++++-
 core/math/integers/integers.factor                 |  6 +++++-
 core/syntax/syntax-docs.factor                     | 11 -----------
 6 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/basis/math/combinatorics/combinatorics-docs.factor b/basis/math/combinatorics/combinatorics-docs.factor
index 776ab37916..02da187331 100644
--- a/basis/math/combinatorics/combinatorics-docs.factor
+++ b/basis/math/combinatorics/combinatorics-docs.factor
@@ -102,8 +102,6 @@ HELP: each-combination
 { $description "Applies the quotation to each combination of " { $snippet "seq" } " choosing " { $snippet "k" } " elements, in order." } ;
 
 
-IN: math.combinatorics.private
-
 HELP: factoradic
 { $values { "n" integer } { "factoradic" sequence } }
 { $description "Converts a positive integer " { $snippet "n" } " to factoradic form.  The factoradic of an integer is its representation based on a mixed radix numerical system that corresponds to the values of " { $snippet "n" } " factorial." }
diff --git a/basis/math/complex/complex.factor b/basis/math/complex/complex.factor
index 381f21d693..c73315a8df 100644
--- a/basis/math/complex/complex.factor
+++ b/basis/math/complex/complex.factor
@@ -3,7 +3,9 @@
 USING: accessors kernel kernel.private math math.private
 math.functions arrays math.functions.private sequences
 sequences.private parser ;
-IN: math.complex.private
+IN: math.complex
+
+<PRIVATE
 
 M: real real-part ; inline
 M: real imaginary-part drop 0 ; inline
@@ -43,3 +45,5 @@ USE: prettyprint.custom
 M: complex pprint* pprint-object ;
 M: complex pprint-delims drop \ C{ \ } ;
 M: complex >pprint-sequence >rect 2array ;
+
+PRIVATE>
diff --git a/basis/tools/deploy/shaker/strip-destructors.factor b/basis/tools/deploy/shaker/strip-destructors.factor
index 86c08ebcb5..fd505b9c98 100644
--- a/basis/tools/deploy/shaker/strip-destructors.factor
+++ b/basis/tools/deploy/shaker/strip-destructors.factor
@@ -1,6 +1,10 @@
 USE: kernel
-IN: destructors.private
+IN: destructors
+
+<PRIVATE
 
 : register-disposable ( obj -- ) drop ; inline
 
 : unregister-disposable ( obj -- ) drop ; inline
+
+PRIVATE>
diff --git a/core/math/floats/floats.factor b/core/math/floats/floats.factor
index 05eb4d4722..c5882724f4 100644
--- a/core/math/floats/floats.factor
+++ b/core/math/floats/floats.factor
@@ -1,8 +1,9 @@
 ! Copyright (C) 2004, 2010 Slava Pestov, Joe Groff.
 ! See http://factorcode.org/license.txt for BSD license.
 USING: kernel math math.private math.order ;
-IN: math.floats.private
+IN: math.floats
 
+<PRIVATE
 : float-unordered? ( x y -- ? ) [ fp-nan? ] either? ;
 : float-min ( x y -- z ) [ float< ] most ; foldable
 : float-max ( x y -- z ) [ float> ] most ; foldable
@@ -79,3 +80,5 @@ M: float fp-sign double>bits 63 bit? ; inline
 M: float neg? fp-sign ; inline
 
 M: float abs double>bits 63 2^ bitnot bitand bits>double ; inline
+
+PRIVATE>
diff --git a/core/math/integers/integers.factor b/core/math/integers/integers.factor
index 7aae3c5362..7cc3b3448f 100644
--- a/core/math/integers/integers.factor
+++ b/core/math/integers/integers.factor
@@ -3,7 +3,9 @@
 ! See http://factorcode.org/license.txt for BSD license.
 USING: combinators kernel kernel.private math math.order
 math.private ;
-IN: math.integers.private
+IN: math.integers
+
+<PRIVATE
 
 : fixnum-min ( x y -- z ) [ fixnum< ] most ; foldable
 : fixnum-max ( x y -- z ) [ fixnum> ] most ; foldable
@@ -186,3 +188,5 @@ M: fixnum /f
     { bignum } declare 1 >bignum bignum/f ;
 
 M: bignum >float bignum>float ; inline
+
+PRIVATE>
diff --git a/core/syntax/syntax-docs.factor b/core/syntax/syntax-docs.factor
index a91023f222..4670c46022 100644
--- a/core/syntax/syntax-docs.factor
+++ b/core/syntax/syntax-docs.factor
@@ -867,17 +867,6 @@ HELP: <PRIVATE
         ""
         ": fac ( n -- n! ) 1 swap (fac) ;"
     }
-    "The above is equivalent to:"
-    { $code
-        "IN: factorial.private"
-        ""
-        ": (fac) ( accum n -- n! )"
-        "    dup 1 <= [ drop ] [ [ * ] keep 1 - (fac) ] if ;"
-        ""
-        "IN: factorial"
-        ""
-        ": fac ( n -- n! ) 1 swap (fac) ;"
-    }
 } ;
 
 HELP: PRIVATE>