steve
/
factor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add test case to memory-tests.factor for recent large object allocation bug

db4
Slava Pestov 2011-09-05 16:27:55 -07:00
parent ed9cf9e4fd
commit 9c29511eb4
1 changed files with 43 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
core/memory/memory-tests.factor
View File

@ -1,34 +1,56 @@
USING: generic kernel kernel.private math memory prettyprint io USING: accessors kernel kernel.private math memory prettyprint
sequences tools.test words namespaces layouts classes io sequences tools.test words namespaces layouts classes
classes.builtin arrays quotations io.launcher system ; classes.builtin arrays quotations system ;
FROM: tools.memory => data-room code-room ;
IN: memory.tests IN: memory.tests
[ save-image-and-exit ] must-fail
! Tests for 'instances'
[ [ ] instances ] must-infer
2 [ [ [ 3 throw ] instances ] must-fail ] times
! Tests for 'become'
[ ] [ { } { } become ] unit-test [ ] [ { } { } become ] unit-test
! LOL ! Bug found on Windows build box, having too many words in the
[ ] [ ! image breaks 'become'
vm [ ] [ 100000 [ f <uninterned-word> ] replicate { } { } become drop ] unit-test
"-i=" image append
"-generations=2"
"-e=USING: memory io prettyprint system ; input-stream gc . 0 exit"
4array try-process
] unit-test
[ [ ] instances ] must-infer ! Bug: code heap collection had to be done when data heap was
! full, not just when code heap was full. If the code heap
! Code GC wasn't kicking in when needed ! contained dead code blocks referring to large data heap
! objects, those large objects would continue to live on even
! if the code blocks were not reachable, as long as the code
! heap did not fill up.
: leak-step ( -- ) 800000 f <array> 1quotation call( -- obj ) drop ; : leak-step ( -- ) 800000 f <array> 1quotation call( -- obj ) drop ;
: leak-loop ( -- ) 100 [ leak-step ] times ; : leak-loop ( -- ) 100 [ leak-step ] times ;
[ ] [ leak-loop ] unit-test [ ] [ leak-loop ] unit-test
TUPLE: testing x y z ; ! Bug: allocation of large objects directly into tenured space
! can proceed past the high water mark.
!
! Suppose the nursery and aging spaces are mostly comprised of
! reachable objects. When doing a full GC, objects from young
! generations ere promoted *before* unreachable objects in
! tenured space are freed by the sweep phase. So if large object
! allocation filled up the heap past the high water mark, this
! promotion might trigger heap growth, even if most of those
! large objects are unreachable.
SYMBOL: foo
[ save-image-and-exit ] must-fail [ ] [
gc
! Erg's bug data-room tenured>> size>>
2 [ [ [ 3 throw ] instances ] must-fail ] times
10 [
! Bug found on Windows build box, having too many words in the image breaks 'become' 4 [ 120 1024 * f <array> ] replicate foo set-global
[ ] [ 100000 [ f <uninterned-word> ] replicate { } { } become drop ] unit-test 100 [ 256 1024 * f <array> drop ] times
] times
data-room tenured>> size>>
assert=
] unit-test