From a6ce3e91133fff0808bdfc5d9116a027bf188d21 Mon Sep 17 00:00:00 2001 From: Doug Coleman Date: Thu, 3 Jul 2014 12:12:46 -0700 Subject: [PATCH] compiler.tree.modular-arithmetic: Don't require that fixnum+ works on tuple slots marked fixnum. This is probably a speed regression. XXX revisit --- .../modular-arithmetic/modular-arithmetic-tests.factor | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/basis/compiler/tree/modular-arithmetic/modular-arithmetic-tests.factor b/basis/compiler/tree/modular-arithmetic/modular-arithmetic-tests.factor index 8b7c3a57f5..0e6161078a 100644 --- a/basis/compiler/tree/modular-arithmetic/modular-arithmetic-tests.factor +++ b/basis/compiler/tree/modular-arithmetic/modular-arithmetic-tests.factor @@ -21,10 +21,12 @@ IN: compiler.tree.modular-arithmetic.tests TUPLE: declared-fixnum { x fixnum } ; -[ t ] [ - [ { declared-fixnum } declare [ 1 + ] change-x ] - { + fixnum+ >fixnum } inlined? -] unit-test +! XXX: As of .97, we do a bounds check and throw an error on overflow, so we can't +! use fixnum+ here. If this is too big a regression, we can revert it. +! [ t ] [ + ! [ { declared-fixnum } declare [ 1 + ] change-x ] + ! { + fixnum+ >fixnum } inlined? +! ] unit-test [ t ] [ [ { declared-fixnum } declare x>> drop ]