Cleanups and fixes

TODO.FACTOR.txt

@@ -19,7 +19,6 @@
 - we need to optimize  [ dup array? [ array? ] [ array? ] if ]
 - better way of dealing with compiler errors
 - track individual method usages
-- modularize core
 - track module files and modification times, and a list of assets loaded
   from that file
 - 'changes' word, asks if files changed on disk from loaded modules

contrib/vim/vim.factor

@@ -2,8 +2,6 @@ IN: vim
 USING: definitions embedded io kernel parser prettyprint process
 sequences namespaces ;
 
-: file-modified stat fourth ;
-
 : vim-location ( file line -- )
     >r [ file-modified ] keep r>
     [ "vim \"" % over % "\" +" % # ] "" make system drop

library/compiler/load.factor

@@ -55,7 +55,7 @@ PROVIDE: library/compiler {
     "test/bail-out.factor"
     "test/intrinsics.factor"
     "test/float.factor"
-    "test/identities" 
+    "test/identities.factor"
     "test/optimizer.factor"
     "test/alien.factor"
     "test/callbacks.factor"

library/io/files.factor

@@ -19,6 +19,8 @@ strings styles ;
 
 : file-length ( path -- n ) stat third ;
 
+: file-modified ( path -- n ) stat fourth ;
+
 : parent-dir ( path -- parent )
     CHAR: / over last-index CHAR: \\ pick last-index max
     dup -1 = [ 2drop "." ] [ head ] if ;

library/load.factor

@@ -95,8 +95,7 @@ PROVIDE: library {
     "tools/listener.factor"
     "tools/inspector.factor"
     "tools/word-tools.factor"
-    
-    "test/test.factor"
+    "tools/test.factor"
 
     "tools/interpreter.factor"
 
@@ -179,7 +178,6 @@ PROVIDE: library {
     "syntax/parser.facts"
     "syntax/parse-syntax.facts"
     "syntax/prettyprint.facts"
-    "test/test.facts"
     "tools/definitions.facts"
     "tools/word-tools.facts"
     "tools/debugger.facts"
@@ -188,6 +186,7 @@ PROVIDE: library {
     "tools/inspector.facts"
     "tools/listener.facts"
     "tools/memory.facts"
+    "tools/test.facts"
 }
 ! Test files
 {
@@ -231,5 +230,5 @@ PROVIDE: library {
     "test/stream.factor"
     "test/threads.factor"
     "test/tuple.factor"
-    "test/words"
+    "test/words.factor"
 } ;

library/modules.factor

@@ -49,10 +49,11 @@ SYMBOL: modules
     [ module-files run-resources ] keep
     dup module-name modules get set-hash ;
 
-: test ( name -- ) module module-tests run-tests ;
+: test-module ( name -- ) module module-tests run-tests ;
 
-: tests ( -- )
-    modules hash-keys [ module-tests ] map concat run-tests ;
+: test-modules ( -- )
+    modules get hash-values
+    [ module-tests ] map concat run-tests ;
 
 : modules. ( -- )
     modules get hash-keys natural-sort [ print ] each ;

library/modules.facts

@@ -45,9 +45,9 @@ HELP: provide
 { $values { "name" "a string" } { "files" "a sequence of strings" } { "tests" "a sequence of strings" } }
 { $description "Registers a module definition and loads its source files. Usually instead of calling this word, module definitions use the parsing word " { $link POSTPONE: PROVIDE: } " instead." } ;
 
-HELP: test
+HELP: test-module
 { $values { "name" "a module name string" } }
 { $description "Runs the unit test files associated to the module by a previous call to " { $link provide } " or " { $link POSTPONE: PROVIDE: } "." } ;
 
-HELP: tests
+HELP: test-modules
 { $description "Runs unit test files for all loaded modules." } ;

library/tools/definitions.factor

@@ -5,7 +5,7 @@ USING: arrays errors generic hashtables io kernel math
 namespaces parser prettyprint sequences styles words ;
 
 : ?resource-path ( path -- path )
-    "resource:/" ?head [ resource-path ] when ;
+    "resource:" ?head [ resource-path ] when ;
 
 : where ( defspec -- loc )
     where* dup [ first2 >r ?resource-path r> 2array ] when ;

library/tools/test.factor

@@ -44,7 +44,7 @@ SYMBOL: failures
 : test-handler ( name quot -- ? )
     catch [ dup error. 2array failure f ] [ t ] if* ;
 
-: test ( path -- ? )
+: run-test ( path -- ? )
     [
         "=====> " write dup write "..." print flush
         [