steve
/
factor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Another identity in value numbering for bitfields

db4
Daniel Ehrenberg 2009-10-08 15:20:42 -05:00
parent baf754236f
commit bb93543054
3 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
basis/classes/struct/bit-accessors/bit-accessors.factor
View File

@ -4,7 +4,7 @@ USING: kernel sequences math fry locals math.order alien.accessors ;
IN: classes.struct.bit-accessors IN: classes.struct.bit-accessors
! Bitfield accessors are little-endian on all platforms ! Bitfield accessors are little-endian on all platforms
! Why not? It's platform-dependent in C ! Why not? It's unspecified in C
: ones-between ( start end -- n ) : ones-between ( start end -- n )
[ 2^ 1 - ] bi@ swap bitnot bitand ; [ 2^ 1 - ] bi@ swap bitnot bitand ;

4
basis/compiler/tree/propagation/propagation-tests.factor
View File

@ -902,3 +902,7 @@ M: tuple-with-read-only-slot clone
[ t ] [ [ alien-unsigned-1 255 bitand ] { bitand fixnum-bitand } inlined? ] unit-test [ t ] [ [ alien-unsigned-1 255 bitand ] { bitand fixnum-bitand } inlined? ] unit-test
[ t ] [ [ alien-unsigned-1 255 swap bitand ] { bitand fixnum-bitand } inlined? ] unit-test [ t ] [ [ alien-unsigned-1 255 swap bitand ] { bitand fixnum-bitand } inlined? ] unit-test
[ t ] [ [ { fixnum } declare 256 rem -256 bitand ] { fixnum-bitand } inlined? ] unit-test
[ t ] [ [ { fixnum } declare 250 rem -256 bitand ] { fixnum-bitand } inlined? ] unit-test
[ f ] [ [ { fixnum } declare 257 rem -256 bitand ] { fixnum-bitand } inlined? ] unit-test

29
basis/compiler/tree/propagation/transforms/transforms.factor
View File

@ -45,13 +45,26 @@ IN: compiler.tree.propagation.transforms
: simplify-bitand? ( value -- ? ) : simplify-bitand? ( value -- ? )
value-info literal>> positive-fixnum? ; value-info literal>> positive-fixnum? ;
: all-ones? ( int -- ? )
dup 1 + bitand zero? ; inline
: redundant-bitand? ( var 111... -- ? ) : redundant-bitand? ( var 111... -- ? )
[ value-info ] bi@ { [ [ value-info ] bi@ [ interval>> ] [ literal>> ] bi* {
nip literal>> [ nip integer? ]
{ [ positive-fixnum? ] [ dup 1 + bitand zero? ] } 1&& [ nip all-ones? ]
] [ [ 0 swap [a,b] interval-subset? ]
[ interval>> ] [ literal>> ] bi* 0 swap [a,b] interval-subset? } 2&& ;
] } 2&& ;
: (zero-bitand?) ( value-info value-info' -- ? )
[ interval>> ] [ literal>> ] bi* {
[ nip integer? ]
[ nip bitnot all-ones? ]
[ 0 swap bitnot [a,b] interval-subset? ]
} 2&& ;
: zero-bitand? ( var1 var2 -- ? )
[ value-info ] bi@
{ [ (zero-bitand?) ] [ swap (zero-bitand?) ] } 2|| ;
{ {
bitand-integer-integer bitand-integer-integer
@ -61,6 +74,10 @@ IN: compiler.tree.propagation.transforms
} [ } [
[ [
{ {
{
[ dup in-d>> first2 zero-bitand? ]
[ drop [ 2drop 0 ] ]
}
{ {
[ dup in-d>> first2 redundant-bitand? ] [ dup in-d>> first2 redundant-bitand? ]
[ drop [ drop ] ] [ drop [ drop ] ]