steve
/
factor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cpu.x86: GC root offsets were computed wrong in words containing alien calls

db4
Slava Pestov 2010-05-04 02:50:25 -04:00
parent 8ccb56c924
commit dd2a4c2c77
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
basis/compiler/tests/codegen.factor
View File

@ -462,3 +462,13 @@ TUPLE: myseq { underlying1 byte-array read-only } { underlying2 byte-array read-
1 1 1 1
[ [ HEX: f bitand ] bi@ [ shift ] [ drop -3 shift ] 2bi ] compile-call [ [ HEX: f bitand ] bi@ [ shift ] [ drop -3 shift ] 2bi ] compile-call
] unit-test ] unit-test
! GC root offsets were computed wrong on x86
: gc-root-messup ( a -- b )
dup [
1024 (byte-array) 2array
10 void* "libc" "malloc" { ulong } alien-invoke
void "libc" "free" { void* } alien-invoke
] when ;
[ ] [ 2000 [ "hello" clone dup gc-root-messup first eq? t assert= ] times ] unit-test

2
basis/cpu/x86/x86.factor
View File

@ -45,7 +45,7 @@ HOOK: extra-stack-space cpu ( stack-frame -- n )
: param@ ( n -- op ) reserved-stack-space + stack@ ; : param@ ( n -- op ) reserved-stack-space + stack@ ;
: gc-root-offsets ( seq -- seq' ) : gc-root-offsets ( seq -- seq' )
[ n>> special-offset ] map f like ; [ n>> spill-offset special-offset ] map f like ;
: decr-stack-reg ( n -- ) : decr-stack-reg ( n -- )
dup 0 = [ drop ] [ stack-reg swap SUB ] if ; dup 0 = [ drop ] [ stack-reg swap SUB ] if ;