steve
/
factor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Better CFG checker

db4
Slava Pestov 2009-05-27 18:58:14 -05:00
parent dadb9a2c50
commit f3688c9373
1 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
basis/compiler/cfg/checker/checker.factor
View File

@ -1,12 +1,13 @@
! Copyright (C) 2009 Slava Pestov. ! Copyright (C) 2009 Slava Pestov.
! See http://factorcode.org/license.txt for BSD license. ! See http://factorcode.org/license.txt for BSD license.
USING: kernel compiler.cfg.instructions compiler.cfg.rpo sequences USING: kernel compiler.cfg.instructions compiler.cfg.rpo compiler.cfg.def-use
combinators.short-circuit accessors ; compiler.cfg.linearization combinators.short-circuit accessors math
sequences sets ;
IN: compiler.cfg.checker IN: compiler.cfg.checker
ERROR: last-insn-not-a-jump insn ; ERROR: last-insn-not-a-jump insn ;
: check-basic-block ( bb -- ) : check-last-instruction ( bb -- )
peek dup { peek dup {
[ ##branch? ] [ ##branch? ]
[ ##conditional-branch? ] [ ##conditional-branch? ]
@ -18,8 +19,28 @@ ERROR: last-insn-not-a-jump insn ;
[ ##dispatch-label? ] [ ##dispatch-label? ]
} 1|| [ drop ] [ last-insn-not-a-jump ] if ; } 1|| [ drop ] [ last-insn-not-a-jump ] if ;
ERROR: bad-loop-entry ;
: check-loop-entry ( bb -- )
dup length 2 >= [
2 head* [ ##loop-entry? ] any?
[ bad-loop-entry ] when
] [ drop ] if ;
: check-basic-block ( bb -- )
[ check-last-instruction ] [ check-loop-entry ] bi ;
: check-rpo ( rpo -- ) : check-rpo ( rpo -- )
[ instructions>> check-basic-block ] each ; [ instructions>> check-basic-block ] each ;
ERROR: undefined-values uses defs ;
: check-mr ( mr -- )
! Check that every used register has a definition
instructions>>
[ [ uses-vregs ] map concat ]
[ [ defs-vregs ] map concat ] bi
2dup subset? [ 2drop ] [ undefined-values ] if ;
: check-cfg ( cfg -- ) : check-cfg ( cfg -- )
reverse-post-order check-rpo ; [ reverse-post-order check-rpo ] [ build-mr check-mr ] bi ;