From 65b1a62f6aa01b09c67af5362788b05aa84f98f0 Mon Sep 17 00:00:00 2001 From: James Cash Date: Tue, 13 Jan 2009 22:58:39 -0500 Subject: [PATCH 1/3] Fixes to v-checkbox --- basis/validators/validators-docs.factor | 2 +- basis/validators/validators.factor | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/basis/validators/validators-docs.factor b/basis/validators/validators-docs.factor index 67c9f4fceb..8f5a587569 100644 --- a/basis/validators/validators-docs.factor +++ b/basis/validators/validators-docs.factor @@ -3,7 +3,7 @@ strings math regexp regexp.backend ; IN: validators HELP: v-checkbox -{ $values { "str" string } } +{ $values { "str" string } { "?" "a boolean" } } { $description "Converts the string value of a checkbox component (either \"on\" or \"off\") to a boolean value." } ; HELP: v-captcha diff --git a/basis/validators/validators.factor b/basis/validators/validators.factor index 04c85cd6db..e49f608e94 100644 --- a/basis/validators/validators.factor +++ b/basis/validators/validators.factor @@ -2,11 +2,11 @@ ! See http://factorcode.org/license.txt for BSD license. USING: kernel continuations sequences math namespaces make sets math.parser math.ranges assocs regexp unicode.categories arrays -hashtables words classes quotations xmode.catalog ; +hashtables words classes quotations xmode.catalog unicode.case ; IN: validators : v-checkbox ( str -- ? ) - "on" = ; + >lower "on" = ; : v-default ( str def -- str/def ) over empty? spin ? ; From 4312bd1be66dc775f2559f2c02749f9954225527 Mon Sep 17 00:00:00 2001 From: Slava Pestov Date: Wed, 14 Jan 2009 00:36:36 -0600 Subject: [PATCH 2/3] Add unportable tag to serial.windows so that its not loaded on Unix --- extra/serial/windows/tags.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 extra/serial/windows/tags.txt diff --git a/extra/serial/windows/tags.txt b/extra/serial/windows/tags.txt new file mode 100644 index 0000000000..6bf68304bb --- /dev/null +++ b/extra/serial/windows/tags.txt @@ -0,0 +1 @@ +unportable From db07cd3f789ad82bbba566d429f200be557b7c04 Mon Sep 17 00:00:00 2001 From: Slava Pestov Date: Wed, 14 Jan 2009 00:37:35 -0600 Subject: [PATCH 3/3] Fix ui.gadgets.scrollers unit tests --- basis/ui/gadgets/scrollers/scrollers-tests.factor | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/basis/ui/gadgets/scrollers/scrollers-tests.factor b/basis/ui/gadgets/scrollers/scrollers-tests.factor index d6792abd49..25977cd906 100644 --- a/basis/ui/gadgets/scrollers/scrollers-tests.factor +++ b/basis/ui/gadgets/scrollers/scrollers-tests.factor @@ -28,7 +28,7 @@ IN: ui.gadgets.scrollers.tests "v" get [ [ { 10 20 } ] [ "v" get model>> range-value ] unit-test - [ { 10 20 } ] [ "g" get rect-loc vneg { 3 3 } v+ ] unit-test + [ { 10 20 } ] [ "g" get rect-loc vneg viewport-gap v+ scroller-border v+ ] unit-test ] with-grafted-gadget [ ] [ @@ -43,13 +43,13 @@ IN: ui.gadgets.scrollers.tests "s" get [ [ { 34 34 } ] [ "s" get viewport>> rect-dim ] unit-test - [ { 106 106 } ] [ "s" get viewport>> viewport-dim ] unit-test + [ { 107 107 } ] [ "s" get viewport>> viewport-dim ] unit-test [ ] [ { 0 0 } "s" get scroll ] unit-test [ { 0 0 } ] [ "s" get model>> range-min-value ] unit-test - [ { 106 106 } ] [ "s" get model>> range-max-value ] unit-test + [ { 107 107 } ] [ "s" get model>> range-max-value ] unit-test [ ] [ { 10 20 } "s" get scroll ] unit-test @@ -57,7 +57,7 @@ IN: ui.gadgets.scrollers.tests [ { 10 20 } ] [ "s" get viewport>> model>> range-value ] unit-test - [ { 10 20 } ] [ "g" get rect-loc vneg { 3 3 } v+ ] unit-test + [ { 10 20 } ] [ "g" get rect-loc vneg viewport-gap v+ scroller-border v+ ] unit-test ] with-grafted-gadget { 600 400 } >>dim "g1" set @@ -102,7 +102,7 @@ dup layout swap dup quot>> call dup layout model>> dependencies>> [ range-max value>> ] map - viewport-gap 2 v*n = + viewport-padding = ] unit-test \ must-infer